-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled uncontrolled/un-controlled open behaviour for DatePicker
#4500
Open
mark-tate
wants to merge
4
commits into
main
Choose a base branch
from
open-interactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+530
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ed601d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mark-tate
force-pushed
the
open-interactions
branch
from
December 13, 2024 18:01
c966b4f
to
f86f05b
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
December 13, 2024 18:28
f86f05b
to
566414a
Compare
mark-tate
force-pushed
the
open-interactions
branch
2 times, most recently
from
December 13, 2024 21:51
bce766b
to
17242e8
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
December 13, 2024 22:00
17242e8
to
6508d4e
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
December 13, 2024 23:00
6508d4e
to
32e73ab
Compare
mark-tate
added
the
chromatic
Run chromatic on the current PR. Will be removed by the CI once submitted.
label
Dec 16, 2024
github-actions
bot
removed
the
chromatic
Run chromatic on the current PR. Will be removed by the CI once submitted.
label
Dec 16, 2024
mark-tate
force-pushed
the
open-interactions
branch
from
December 16, 2024 16:20
da8186f
to
882b2e2
Compare
joshwooding
reviewed
Dec 17, 2024
- added `openOnClick`, `openOnKeyDown` and `openOnFocus` props to `DatePicker`. - revise the controlled behaviour of the `open` prop on `DatePickerOverlay`. - add examples for controlled and uncontrolled behaviour.
mark-tate
force-pushed
the
open-interactions
branch
from
December 20, 2024 15:04
882b2e2
to
3cea7c6
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
December 20, 2024 15:05
3cea7c6
to
1ed601d
Compare
mark-tate
added
the
chromatic
Run chromatic on the current PR. Will be removed by the CI once submitted.
label
Dec 20, 2024
github-actions
bot
removed
the
chromatic
Run chromatic on the current PR. Will be removed by the CI once submitted.
label
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openOnClick
,openOnKeyDown
andopenOnFocus
props toDatePicker
.open
prop onDatePickerOverlay
.