Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled uncontrolled/un-controlled open behaviour for DatePicker #4500

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mark-tate
Copy link
Contributor

  • added openOnClick, openOnKeyDown and openOnFocus props to DatePicker.
  • revise the controlled behaviour of the open prop on DatePickerOverlay.
  • add examples for controlled and uncontrolled behaviour.

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 1ed601d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/lab Minor
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 3:13pm

@mark-tate mark-tate force-pushed the open-interactions branch 2 times, most recently from bce766b to 17242e8 Compare December 13, 2024 21:51
@mark-tate mark-tate added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 16, 2024
@mark-tate mark-tate marked this pull request as ready for review December 16, 2024 16:14
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 16, 2024
- added `openOnClick`, `openOnKeyDown` and `openOnFocus` props to `DatePicker`.
- revise the controlled behaviour of the `open` prop on `DatePickerOverlay`.
- add examples for controlled and uncontrolled behaviour.
@mark-tate mark-tate added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 20, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants